Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message if sequence key present in context columns #2108

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Add error message if sequence key present in context columns #2108

merged 10 commits into from
Jul 8, 2024

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jul 3, 2024 •
edited

@gsheni gsheni self-assigned this Jul 3, 2024
@gsheni gsheni marked this pull request as ready for review July 3, 2024 19:38
@gsheni gsheni requested a review from a team as a code owner July 3, 2024 19:38
@gsheni gsheni requested review from frances-h, amontanez24 and lajohn4747 and removed request for a team and frances-h July 3, 2024 19:38
@sdv-team
Copy link
Contributor

sdv-team commented Jul 3, 2024

Task linked: CU-86b11ypbf SDV - Context column cannot be a sequence key: Need better error message for this case #2097

@gsheni gsheni requested a review from pvk-developer July 5, 2024 14:39
pvk-developer
pvk-developer requested changes Jul 8, 2024
View reviewed changes
sdv/sequential/par.py Outdated Show resolved Hide resolved
tests/integration/sequential/test_par.py Show resolved Hide resolved
amontanez24
amontanez24 reviewed Jul 8, 2024
View reviewed changes
sdv/sequential/par.py Outdated Show resolved Hide resolved
tests/unit/sequential/test_par.py Outdated Show resolved Hide resolved
@gsheni gsheni requested a review from amontanez24 July 8, 2024 22:10
@gsheni gsheni merged commit b34b088 into main Jul 8, 2024
39 checks passed
@gsheni gsheni deleted the 2097-context-column-cannot-be-a-sequence-key-need-better-error-message-for-this-case branch July 8, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@pvk-developer pvk-developer pvk-developer approved these changes

@lajohn4747 lajohn4747 Awaiting requested review from lajohn4747

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context column cannot be a sequence key: Need better error message for this case
5 participants
@gsheni @sdv-team @amontanez24 @lajohn4747 @pvk-developer